Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds initial support for a Zadara storage backend in Sunbeam by introducing a new backend implementation plus unit tests and fixture wiring so the backend participates in the shared backend test suite.
Changes:
- Introduce
ZadaraBackendandZadaraConfigundersunbeam.storage.backends.zadara. - Add a new unit test module for the Zadara backend/config validation.
- Extend backend test fixtures and common “all backends” assertions to include Zadara.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
sunbeam-python/sunbeam/storage/backends/zadara/backend.py |
New backend + pydantic config model for ZadaraVPSA iSCSI. |
sunbeam-python/sunbeam/storage/backends/zadara/__init__.py |
Declares the new backend package. |
sunbeam-python/tests/unit/sunbeam/storage/backends/test_zadara.py |
Adds Zadara-specific tests (type/charm name, secret marking, protocol validation). |
sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py |
Includes Zadara in shared uniqueness/expectations tests. |
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py |
Adds zadara_backend fixture and includes it in any_backend parametrization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahmad-can
force-pushed
the
feature/generate-zadara-charm
branch
from
eb80464 to
fcbd8c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/984541